Re: [Qemu-devel] [v4 2/6] hw/i386: enforce SID verification

[Peter Xu]

On Mon, Sep 12, 2016 at 01:08:05PM +0300, David Kiarie wrote:
> Platform devices are now able to make interrupt request with
> explicit SIDs hence we can safely expect triggered AddressSpace ID
> to match the requesting ID
> 
> Signed-off-by: David Kiarie <address@hidden>
> ---
>  hw/i386/intel_iommu.c | 77 
> ++++++++++++++++++++++++++-------------------------
>  1 file changed, 39 insertions(+), 38 deletions(-)
> 
> diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
> index 496d836..e4bad6a 100644
> --- a/hw/i386/intel_iommu.c
> +++ b/hw/i386/intel_iommu.c
> @@ -2043,43 +2043,41 @@ static int vtd_irte_get(IntelIOMMUState *iommu, 
> uint16_t index,
>          return -VTD_FR_IR_IRTE_RSVD;
>      }
>  
> -    if (sid != X86_IOMMU_SID_INVALID) {

Btw, if we removed all references of X86_IOMMU_SID_INVALID, we can
just remove the defination as well in this patch.

Thanks,

-- peterx