Re: [Qemu-devel] [PATCH v2 1/9] log: Add new IOMMU type

[Prem Mallappa]

On Fri, Sep 9, 2016 at 9:06 PM, Auger Eric <address@hidden> wrote:

> Hi Prem,
>
> Missing commit message
>
> > Signed-off-by: Prem Mallappa <address@hidden>
> > ---
> >  include/qemu/log.h | 1 +
> >  util/log.c         | 2 ++
> >  2 files changed, 3 insertions(+)
> >
> > diff --git a/include/qemu/log.h b/include/qemu/log.h
> > index 234fa81..3dd2131 100644
> > --- a/include/qemu/log.h
> > +++ b/include/qemu/log.h
> > @@ -42,6 +42,7 @@ static inline bool qemu_log_separate(void)
> >  #define CPU_LOG_TB_NOCHAIN (1 << 13)
> >  #define CPU_LOG_PAGE       (1 << 14)
> >  #define LOG_TRACE          (1 << 15)
> > +#define CPU_LOG_IOMMU      (1 << 16)
> why is it prefixed with CPU_ ?
> besides all arm gic devices seem to use LOG_GUEST_ERROR. what is the
> rationale behind introducing a new enum?
>

Will change this to LOG_GUEST_ERROR, if others on the list are okay.


-- 
Cheers,
/Prem