Re: [Qemu-devel] [PATCH v6 18/18] Replace qmp-commands.hx by docs/qmp-commands.txt

[Markus Armbruster]

Eric Blake <address@hidden> writes:

> On 09/12/2016 04:19 AM, Marc-André Lureau wrote:
>> The only remaining function of qmp-commands.hx is to let us generate
>> qmp-commands.txt from it.  Replace qmp-commands.hx by qmp-commands.txt.
>> 
>> We intend to move the documentation into the QAPI schema and generate
>> qapi-commands.txt from it, but not right now.
>> 
>> Signed-off-by: Marc-André Lureau <address@hidden>
>> ---
>>  Makefile                                 |    6 +-
>>  .gitignore                               |    1 -
>>  MAINTAINERS                              |    1 -
>>  docs/qapi-code-gen.txt                   |    6 +-
>>  qmp-commands.hx => docs/qmp-commands.txt | 1127 
>> ------------------------------
>>  docs/writing-qmp-commands.txt            |   38 -
>>  6 files changed, 4 insertions(+), 1175 deletions(-)
>>  rename qmp-commands.hx => docs/qmp-commands.txt (87%)
>> 
>
>> +++ b/MAINTAINERS
>> @@ -1237,7 +1237,6 @@ M: Markus Armbruster <address@hidden>
>>  S: Supported
>>  F: qmp.c
>>  F: monitor.c
>> -F: qmp-commands.hx
>>  F: docs/*qmp-*
>>  F: scripts/qmp/
>>  T: git git://repo.or.cz/qemu/armbru.git qapi-next
>
> Shouldn't we be adding F: qmp-commands.txt somewhere to the file in the
> interim, at least until the promised later patch lands that once again
> generates documentation (this time from .json files)?

It's covered by the existing F: docs/*qmp-* line.