Re: [Qemu-devel] [virtio-dev] Re: [PATCH v2 02/15] crypto: introduce crypto queue handler

[Ola Liljedahl]

On 13/09/2016, 12:58, "address@hidden on behalf of Paolo
Bonzini" <address@hidden on behalf of
address@hidden> wrote:

>
>
>On 13/09/2016 11:20, Daniel P. Berrange wrote:
>>> > +typedef struct CryptoPacket CryptoPacket;
>>> > +typedef struct CryptoQueue CryptoQueue;
>>> > +typedef struct CryptoPacketBuf CryptoPacketBuf;
>>> > +
>>> > +typedef void (CryptoPacketSent) (CryptoClientState *, int);
>> As previously, I'd expect naming of
>>
>>  QCryptoCryptodevPacket
>>  QCryptoCryptodevPacketBuf
>>  QCryptoCryptodevQueue
>>
>
>Gonglei,
>
>you are copying a lot of code from network backends.
>
>I am not sure why you would need a queue for virtio-crypto rather than a
>direct connection between frontend and backend (and the backend would be
>QEMU crypto APIs, like Daniel suggested).
What about backends implemented directly in HW? Bypass the middle man.
Make crypto offload meaningful for small size blocks.

‹ Ola

>
>Paolo
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: address@hidden
>For additional commands, e-mail: address@hidden
>

IMPORTANT NOTICE: The contents of this email and any attachments are 
confidential and may also be privileged. If you are not the intended recipient, 
please notify the sender immediately and do not disclose the contents to any 
other person, use it for any purpose, or store or copy the information in any 
medium. Thank you.