Re: [Qemu-devel] [PULL 1/2] block/gluster: add support to choose libgfapi logfile

[Jeff Cody]

On Tue, Sep 13, 2016 at 10:23:32AM -0500, Eric Blake wrote:
> On 09/13/2016 12:42 AM, Jeff Cody wrote:
> > From: Prasanna Kumar Kalever <address@hidden>
> > 
> > currently all the libgfapi logs defaults to '/dev/stderr' as it was 
> > hardcoded
> > in a call to glfs logging api. When the debug level is chosen to 
> > DEBUG/TRACE,
> > gfapi logs will be huge and fill/overflow the console view.
> > 
> > This patch provides a commandline option to mention log file path which 
> > helps
> > in logging to the specified file and also help in persisting the gfapi logs.
> > 
> 
> > +++ b/qapi/block-core.json
> > @@ -2154,13 +2154,16 @@
> >  #
> >  # @debug-level: #optional libgfapi log level (default '4' which is Error)
> >  #
> > +# @logfile:     #optional libgfapi log file (default /dev/stderr)
> > +#
> >  # Since: 2.7
> 
> logfile missed 2.7; please add a '(since 2.8)' designator on the
> @logfile line as a followup patch.
> 
>

Yep, thanks for catching that Eric.