[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 6/9] target-cris: reduce v32isms from v10 log du
From: |
Hans-Peter Nilsson |
Subject: |
Re: [Qemu-devel] [PATCH 6/9] target-cris: reduce v32isms from v10 log dumps |
Date: |
Wed, 14 Sep 2016 14:48:29 +0200 |
> Date: Tue, 13 Sep 2016 00:59:51 +0200
> From: "Edgar E. Iglesias" <address@hidden>
> > @@ -3336,12 +3336,20 @@ void cris_cpu_dump_state(CPUState *cs, FILE *f,
> > fprintf_function cpu_fprintf,
> > {
> > CRISCPU *cpu = CRIS_CPU(cs);
> > CPUCRISState *env = &cpu->env;
> > + const char **regnames;
> > + const char **pregnames;
> > int i;
> > - uint32_t srs;
> >
> > if (!env || !f) {
> > return;
> > }
> > + if (env->pregs[PR_VR] < 32) {
> > + pregnames = pregnames_v10;
> > + regnames = regnames_v10;
> > + } else {
> > + pregnames = pregnames_v32;
> > + regnames = regnames_v32;
> > + }
> >
> > cpu_fprintf(f, "PC=%x CCS=%x btaken=%d btarget=%x\n"
> > "cc_op=%d cc_src=%d cc_dest=%d cc_result=%x cc_mask=%x\n",
> > @@ -3363,14 +3371,16 @@ void cris_cpu_dump_state(CPUState *cs, FILE *f,
> > fprintf_function cpu_fprintf,
> > cpu_fprintf(f, "\n");
> > }
> > }
> > - srs = env->pregs[PR_SRS];
> > - cpu_fprintf(f, "\nsupport function regs bank %x:\n", srs);
> > - if (srs < ARRAY_SIZE(env->sregs)) {
> > - for (i = 0; i < 16; i++) {
> > - cpu_fprintf(f, "s%2.2d=%8.8x ",
> > - i, env->sregs[srs][i]);
> > - if ((i + 1) % 4 == 0) {
> > - cpu_fprintf(f, "\n");
> > + if (env->pregs[PR_SRS] >= 32) {
>
>
> did you mean env->pregs[PR_VR] >= 32 here?
Oops! Most definitely yes.
brgds, H-P
- Re: [Qemu-devel] [PATCH 8/9] target-cris: add v17 CPU, (continued)
- [Qemu-devel] [PATCH 5/9] target-cris: sync CC state at load/stores., Rabin Vincent, 2016/09/05
- [Qemu-devel] [PATCH 6/9] target-cris: reduce v32isms from v10 log dumps, Rabin Vincent, 2016/09/05
- [Qemu-devel] [PATCH 4/9] tests: cris: remove check_time1, Rabin Vincent, 2016/09/05
- Re: [Qemu-devel] [PATCH 1/9] tests: cris: force inlining, Edgar E. Iglesias, 2016/09/06
- Re: [Qemu-devel] [PATCH 1/9] tests: cris: force inlining, Peter Maydell, 2016/09/08