[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] migration: Fix seg with missing port
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH] migration: Fix seg with missing port |
|
Date: |
Thu, 15 Sep 2016 16:28:59 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 |
On 12/09/2016 21:03, Dr. David Alan Gilbert (git) wrote:
> SocketAddress *saddr = tcp_build_address(host_port, errp);
> - socket_start_outgoing_migration(s, saddr, errp);
> + if (!*errp) {
> + socket_start_outgoing_migration(s, saddr, errp);
> + }
> }
>
> void unix_start_outgoing_migration(MigrationState *s,
> @@ -175,7 +177,9 @@ static void socket_start_incoming_migration(SocketAddress
> *saddr,
> void tcp_start_incoming_migration(const char *host_port, Error **errp)
> {
> SocketAddress *saddr = tcp_build_address(host_port, errp);
> - socket_start_incoming_migration(saddr, errp);
> + if (!*errp) {
> + socket_start_incoming_migration(saddr, errp);
> + }
FWIW, this less-boilerplate version was almost fine, just replace
"!*errp" with "saddr".
Paolo