Re: [Qemu-devel] [PATCH 05/10] block: Accept device model name for x-blockdev-insert-medium

[Eric Blake]

On 09/15/2016 03:37 AM, Kevin Wolf wrote:
> Am 14.09.2016 um 22:57 hat Eric Blake geschrieben:
>> On 08/19/2016 11:50 AM, Kevin Wolf wrote:
>>> In order to remove the necessity to use BlockBackend names in the
>>> external API, we want to allow qdev device names in all device related
>>> commands.
>>>
>>> This converts x-blockdev-insert-medium to accept a qdev device name.
>>
>> Since this command is experimental...
>>
>>> Signed-off-by: Kevin Wolf <address@hidden>
>>> ---
>>
>>> +++ b/qapi/block-core.json
>>> @@ -2380,14 +2380,17 @@
>>>  # This command is still a work in progress and is considered experimental.
>>>  # Stay away from it unless you want to help with its development.
>>>  #
>>> -# @device:    block device name
>>> +# @device:    block device name (deprecated, use @id instead)
>>> +#
>>> +# @id:        the name or QOM path of the guest device (since: 2.8)
>>
>> ...why even bother to deprecate 'device'?  Can't we just do a whole-sale
>> switch to a required 'id' only?  Or should such a wholesale switch be
>> reserved for the day that we remove the x- prefix when promoting the
>> command to stable?
> 
> I tried this for the experimental commands, but I think it required some
> more test case rewrites, so I decided to leave it for later. Not
> necessarily "when promoting to stable" later, but a separate series
> anyway.

Fair enough.  Maybe mention it in the commit message, or even in a
comment that part of promoting to stable may include removing the
'driver' parameter.  That way, we won't forget the discussion.  But in
the meantime, the conversion looks sane, so I'm okay with adding:
Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature