Re: [Qemu-devel] [PULL 00/17] Second batch of misc patches for QEMU 2.8

[no-reply]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PULL 00/17] Second batch of misc patches for QEMU 2.8

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Auto packing the repository in background for optimum performance.
See "git help gc" for manual housekeeping.
Switched to a new branch 'test'
4b80bab pcspk: adding vmstate for save/restore
daef00a kvmvapic: fix state change handler
99c4925 pc: apic: introduce APIC macro
d84b10f target-i386: Fixed syscall posssible segfault
1ddfa81 log: fix parsing of multiple trace:PATTERN log args
6f42bd4 qemu-char: avoid segfault if user lacks of permisson of a given logfile
b8dc087 build-sys: add make 'help' target
57a4b3c linux-user: complete omission of removing uses of strdup
399336b target-i386: fix ordering of fields in CPUX86State
c6ead6f pc: apic: fix touch LAPIC when irqchip is split
f3d7a79 scsi: pvscsi: limit process IO loop to ring size
4e40872 memory: remove memory_region_destructor_rom_device
14100b8 Change net/socket.c to use socket_*() functions
0549857 cutils: Rewrite x86 buffer zero checking
b99e8b8 scsi: mptsas: use g_new0 to allocate MPTSASRequest object
a346070 virtio-scsi: Don't abort when media is ejected
e5eb196 scsi-disk: Cleaning up around tray open state

=== OUTPUT BEGIN ===
Checking PATCH 1/17: scsi-disk: Cleaning up around tray open state...
Checking PATCH 2/17: virtio-scsi: Don't abort when media is ejected...
Checking PATCH 3/17: scsi: mptsas: use g_new0 to allocate MPTSASRequest 
object...
Checking PATCH 4/17: cutils: Rewrite x86 buffer zero checking...
ERROR: architecture specific defines should be avoided
#65: FILE: util/bufferiszero.c:67:
+#if defined(CONFIG_AVX2_OPT) || defined(__SSE2__)

ERROR: architecture specific defines should be avoided
#214: FILE: util/bufferiszero.c:206:
+# ifndef __SSE2__

total: 2 errors, 0 warnings, 296 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 5/17: Change net/socket.c to use socket_*() functions...
Checking PATCH 6/17: memory: remove memory_region_destructor_rom_device...
Checking PATCH 7/17: scsi: pvscsi: limit process IO loop to ring size...
Checking PATCH 8/17: pc: apic: fix touch LAPIC when irqchip is split...
Checking PATCH 9/17: target-i386: fix ordering of fields in CPUX86State...
Checking PATCH 10/17: linux-user: complete omission of removing uses of 
strdup...
Checking PATCH 11/17: build-sys: add make 'help' target...
Checking PATCH 12/17: qemu-char: avoid segfault if user lacks of permisson of a 
given logfile...
Checking PATCH 13/17: log: fix parsing of multiple trace:PATTERN log args...
Checking PATCH 14/17: target-i386: Fixed syscall posssible segfault...
Checking PATCH 15/17: pc: apic: introduce APIC macro...
Checking PATCH 16/17: kvmvapic: fix state change handler...
Checking PATCH 17/17: pcspk: adding vmstate for save/restore...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden