[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/7] Add "read-only" to the options QDict
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v2 0/7] Add "read-only" to the options QDict |
Date: |
Fri, 16 Sep 2016 14:51:24 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 15.09.2016 um 16:52 hat Alberto Garcia geschrieben:
> This series adds "read-only" to the options QDict, fixing a
> long-standing problem with the reopening code.
>
> [E] <- [D] <- [C] <- [B] <- [A]
>
> In a normal scenario, the active layer [A] is in read-write mode and
> everything else is read-only. If we reopen [D] in read-write mode and
> later reopen [B], then [D] will become read-only when inheriting the
> flags from its parent (see bdrv_backing_options()). With this series,
> inheriting options doesn't need to override values that have been
> explicitly set before.
>
> The BDRV_O_RDWR flag is not removed yet, but its keep in sync with the
> value of the "read-only" option. Removing the BDRV_O_RDWR flag is not
> straightforward in all cases and can result in code that is
> significantly slower and less readable. Therefore it will be dealt
> with in the future.
Thanks, applied to the block branch.
Kevin
- [Qemu-devel] [PATCH v2 0/7] Add "read-only" to the options QDict, Alberto Garcia, 2016/09/15
- [Qemu-devel] [PATCH v2 1/7] block: Remove bdrv_is_snapshot, Alberto Garcia, 2016/09/15
- [Qemu-devel] [PATCH v2 2/7] block: Set BDRV_O_ALLOW_RDWR and snapshot_options before storing the flags, Alberto Garcia, 2016/09/15
- [Qemu-devel] [PATCH v2 6/7] commit: Add 'base' to the reopen queue before 'overlay_bs', Alberto Garcia, 2016/09/15
- [Qemu-devel] [PATCH v2 5/7] block: Don't queue the same BDS twice in bdrv_reopen_queue_child(), Alberto Garcia, 2016/09/15
- [Qemu-devel] [PATCH v2 7/7] block: rename "read-only" to BDRV_OPT_READ_ONLY, Alberto Garcia, 2016/09/15
- [Qemu-devel] [PATCH v2 3/7] block: Update bs->open_flags earlier in bdrv_open_common(), Alberto Garcia, 2016/09/15
- [Qemu-devel] [PATCH v2 4/7] block: Add "read-only" to the options QDict, Alberto Garcia, 2016/09/15
- Re: [Qemu-devel] [PATCH v2 0/7] Add "read-only" to the options QDict,
Kevin Wolf <=