[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 0/8] 9p patches for 2.8 20160916
From: |
Greg Kurz |
Subject: |
Re: [Qemu-devel] [PULL 0/8] 9p patches for 2.8 20160916 |
Date: |
Fri, 16 Sep 2016 19:36:57 +0200 |
On Fri, 16 Sep 2016 15:46:26 +0100
Peter Maydell <address@hidden> wrote:
> On 16 September 2016 at 15:39, Greg Kurz <address@hidden> wrote:
> > Ok, I'll look into it... but the important part in this pull request is
> > the "9pfs: fix potential segfault during walk" patch. It fixes a regression
> > introduced in 2.7 by the 9P security fixes. And IIUC, Michael Roth is about
> > to release 2.6.1.1 with these fixes and the regression...
> >
> > Should I send a new pull request without the qtest patches ? Or with the
> > regression fix only ?
>
> That's up to you, as long as you don't break "make check".
> You probably want to investigate at least enough to be happy that
> this problem is a bug in the test code, not the feature itself.
>
It is the test code actually: 9P uses little-endian ordering :)
I'll post an updated version which doesn't break "make check" on both
BE and LE hosts, and re-send a pull request.
Cheers.
--
Greg
> thanks
> -- PMM
- [Qemu-devel] [PULL 0/8] 9p patches for 2.8 20160916, Greg Kurz, 2016/09/16
- [Qemu-devel] [PULL 5/8] tests: virtio-9p: introduce start/stop functions, Greg Kurz, 2016/09/16
- [Qemu-devel] [PULL 7/8] tests: virtio-9p: add basic transaction test, Greg Kurz, 2016/09/16
- [Qemu-devel] [PULL 3/8] 9pfs: drop useless v9fs_string_null() function, Greg Kurz, 2016/09/16
- [Qemu-devel] [PULL 8/8] 9pfs: fix potential segfault during walk, Greg Kurz, 2016/09/16
- [Qemu-devel] [PULL 2/8] 9pfs: drop duplicate line in proxy backend, Greg Kurz, 2016/09/16
- [Qemu-devel] [PULL 1/8] 9pfs: drop unused fmt strings in the proxy backend, Greg Kurz, 2016/09/16
- [Qemu-devel] [PULL 6/8] tests: virtio-9p: add basic configuration test, Greg Kurz, 2016/09/16
- [Qemu-devel] [PULL 4/8] 9pfs: introduce v9fs_path_sprintf() helper, Greg Kurz, 2016/09/16