[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 3/6] firmware-qemu_fw_cfg: Rename jump labels in fw_
From: |
SF Markus Elfring |
Subject: |
[Qemu-devel] [PATCH 3/6] firmware-qemu_fw_cfg: Rename jump labels in fw_cfg_register_file() |
Date: |
Sun, 18 Sep 2016 14:53:53 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 |
From: Markus Elfring <address@hidden>
Date: Sun, 18 Sep 2016 11:23:46 +0200
Adjust jump labels according to the current Linux coding style convention.
Signed-off-by: Markus Elfring <address@hidden>
---
drivers/firmware/qemu_fw_cfg.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c
index a229df6..a834d01 100644
--- a/drivers/firmware/qemu_fw_cfg.c
+++ b/drivers/firmware/qemu_fw_cfg.c
@@ -464,12 +464,12 @@ static int fw_cfg_register_file(const struct fw_cfg_file
*f)
err = kobject_init_and_add(&entry->kobj, &fw_cfg_sysfs_entry_ktype,
fw_cfg_sel_ko, "%d", entry->f.select);
if (err)
- goto err_register;
+ goto free_entry;
/* add raw binary content access */
err = sysfs_create_bin_file(&entry->kobj, &fw_cfg_sysfs_attr_raw);
if (err)
- goto err_add_raw;
+ goto delete_object;
/* try adding "/sys/firmware/qemu_fw_cfg/by_name/" symlink */
fw_cfg_build_symlink(fw_cfg_fname_kset, &entry->kobj, entry->f.name);
@@ -477,10 +477,9 @@ static int fw_cfg_register_file(const struct fw_cfg_file
*f)
/* success, add entry to global cache */
fw_cfg_sysfs_cache_enlist(entry);
return 0;
-
-err_add_raw:
+ delete_object:
kobject_del(&entry->kobj);
-err_register:
+ free_entry:
kfree(entry);
return err;
}
--
2.10.0
- [Qemu-devel] [PATCH 0/6] firmware-qemu_fw_cfg: Fine-tuning for four function implementations, SF Markus Elfring, 2016/09/18
- [Qemu-devel] [PATCH 1/6] firmware-qemu_fw_cfg: Use kmalloc_array() in fw_cfg_register_dir_entries(), SF Markus Elfring, 2016/09/18
- [Qemu-devel] [PATCH 2/6] firmware-qemu_fw_cfg: Improve a size determination in fw_cfg_register_file(), SF Markus Elfring, 2016/09/18
- [Qemu-devel] [PATCH 3/6] firmware-qemu_fw_cfg: Rename jump labels in fw_cfg_register_file(),
SF Markus Elfring <=
- [Qemu-devel] [PATCH 4/6] firmware-qemu_fw_cfg: Improve a size determination in fw_cfg_build_symlink(), SF Markus Elfring, 2016/09/18
- [Qemu-devel] [PATCH 5/6] firmware-qemu_fw_cfg: Rename jump labels in fw_cfg_sysfs_probe(), SF Markus Elfring, 2016/09/18
- [Qemu-devel] [PATCH 6/6] firmware-qemu_fw_cfg: Move a variable assignment in fw_cfg_sysfs_probe(), SF Markus Elfring, 2016/09/18
- Re: [Qemu-devel] [PATCH 0/6] firmware-qemu_fw_cfg: Fine-tuning for four function implementations, Gabriel L. Somlo, 2016/09/20