Re: [Qemu-devel] [PATCH v6 7/7] linux-user: Add missing Mips syscalls items in strace.list

[Aleksandar Markovic]

Thanks, I did it hard way: by copying the content of strace.list and headers in 
into columns of a spreadsheet, than processing the content so that each syscall 
has its own row, and after that doing numerous copying and pasting for syscalls 
that did not appear to have support in strace.list. In hindsight, I think 
devising a script or even a set of command lines would be much faster and 
better way of doing this.

Aleksandar
________________________________________
From: Laurent Vivier address@hidden
Sent: Friday, September 16, 2016 12:35 PM
To: Aleksandar Markovic; address@hidden; address@hidden; address@hidden; 
address@hidden; Leon Alrae; Petar Jovanovic; Miodrag Dinic; Aleksandar Rikalo; 
Aleksandar Markovic
Subject: Re: [Qemu-devel] [PATCH v6 7/7] linux-user: Add missing Mips syscalls 
items in strace.list

Le 16/09/2016 à 13:14, Aleksandar Markovic a écrit :
> From: Aleksandar Markovic <address@hidden>
>
> Without this patch, a number of Mips syscalls will be logged in the following
> way (in this examople, this is an invocation of accept4()):
>
>   86906 Unknown syscall 4334
>
> This patch provides standard Qemu's strace output for such cases, like this:
>
>   95861 accept4(3,1996486000,1996486016,128,0,0) = 5
>
> Such output may be further improvad by providing strace-related functions
> that handle only particular syscalls, but this is beyond the scope of
> this patch.
>
> Signed-off-by: Aleksandar Markovic <address@hidden>
> ---
>  linux-user/strace.list | 114 
> +++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 114 insertions(+)

Nice work, we should update strace.list each time we add a syscall (and
personally I don't, it's bad).

How did you choose the list of syscalls to add in this list as some of
them are not implemented in syscall.c?
[for instance "kcmp", I have the patch for it but I don't think I've
already sent it]

Laurent