Re: [Qemu-devel] [PATCH v7 5/7] linux-user: Fix certain argument alignment cases for Mips64

[Laurent Vivier]

Le 19/09/2016 à 13:44, Aleksandar Markovic a écrit :
> From: Aleksandar Markovic <address@hidden>
> 
> The function that is changed in this patch is supposed to indicate that
> there was certain argument rearrangement related to 64-bit arguments on
> 32-bit platforms. The background on such rearrangements can be found,
> for example, in the man page for syscall(2).
> 
> However, for 64-bit Mips architectures there is no such rearrangement,
> and this patch reflects it.
> 
> Signed-off-by: Aleksandar Rikalo <address@hidden>
> Signed-off-by: Aleksandar Markovic <address@hidden>

Reviewed-by: Laurent Vivier <address@hidden>

> ---
>  linux-user/syscall.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index ca06943..4f52f09 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -619,7 +619,7 @@ static inline int next_free_host_timer(void)
>  static inline int regpairs_aligned(void *cpu_env) {
>      return ((((CPUARMState *)cpu_env)->eabi) == 1) ;
>  }
> -#elif defined(TARGET_MIPS)
> +#elif defined(TARGET_MIPS) && (TARGET_ABI_BITS == 32)
>  static inline int regpairs_aligned(void *cpu_env) { return 1; }
>  #elif defined(TARGET_PPC) && !defined(TARGET_PPC64)
>  /* SysV AVI for PPC32 expects 64bit parameters to be passed on odd/even pairs
>