[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 03/10] virtio: stop virtqueue processing if d
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-devel] [PATCH v3 03/10] virtio: stop virtqueue processing if device is broken |
Date: |
Tue, 20 Sep 2016 13:35:06 +0200 |
On Tue, 12 Apr 2016 14:25:27 +0100
Stefan Hajnoczi <address@hidden> wrote:
> QEMU prints an error message and exits when the device enters an invalid
> state. Terminating the process is heavy-handed. The guest may still be
> able to function even if there is a bug in a virtio guest driver.
>
> Moreover, exiting is a bug in nested virtualization where a nested guest
> could DoS other nested guests by killing a pass-through virtio device.
> I don't think this configuration is possible today but it is likely in
> the future.
>
> If the broken flag is set, do not process virtqueues or write back used
> descriptors. The broken flag can be cleared again by resetting the
> device.
>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
> hw/virtio/virtio.c | 39 +++++++++++++++++++++++++++++++++++++++
> include/hw/virtio/virtio.h | 3 +++
> 2 files changed, 42 insertions(+)
Reviewed-by: Cornelia Huck <address@hidden>
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH v3 03/10] virtio: stop virtqueue processing if device is broken,
Cornelia Huck <=