Re: [Qemu-devel] [PATCH] intel-iommu: Check IOAPIC's Trigger Mode against the one in IRTE

[Wu, Feng]

> -----Original Message-----
> From: Peter Xu [mailto:address@hidden
> Sent: Wednesday, September 21, 2016 2:12 PM
> To: Wu, Feng <address@hidden>
> Cc: address@hidden; address@hidden
> Subject: Re: [Qemu-devel] [PATCH] intel-iommu: Check IOAPIC's Trigger Mode
> against the one in IRTE
> 
> On Wed, Sep 21, 2016 at 05:54:40AM +0000, Wu, Feng wrote:
> >
> >
> > > -----Original Message-----
> > > From: Peter Xu [mailto:address@hidden
> > > Sent: Wednesday, September 21, 2016 1:45 PM
> > > To: Wu, Feng <address@hidden>
> > > Cc: address@hidden; address@hidden
> > > Subject: Re: [Qemu-devel] [PATCH] intel-iommu: Check IOAPIC's Trigger
> Mode
> > > against the one in IRTE
> > >
> > > On Thu, Sep 22, 2016 at 12:12:17AM +0800, Feng Wu wrote:
> > > > The Trigger Mode field of IOAPIC must match the Trigger Mode in
> > > > the IRTE according to VT-d Spec 5.1.5.1.
> > > >
> > > > Signed-off-by: Feng Wu <address@hidden>
> > >
> > > Reviewed-by: Peter Xu <address@hidden>
> > >
> > > Could I ask why we want this now? I know that both vector and trigger
> > > mode should not be aligned in current kernel.
> >
> > Oh, I don't aware of this. I was just looking at the code and found seems
> > the Spec says we need to check it. So I added the check. :)
> 
> Yeah, that's good enough a reason. :-)

Thanks for your review :)

Thanks,
Feng

> 
> -- peterx