[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-ppc] [PATCH] net: Add SunGEM device emulation as
From: |
Benjamin Herrenschmidt |
Subject: |
Re: [Qemu-devel] [Qemu-ppc] [PATCH] net: Add SunGEM device emulation as found on Apple UniNorth |
Date: |
Wed, 21 Sep 2016 19:02:39 +1000 |
On Wed, 2016-09-21 at 13:18 +1000, David Gibson wrote:
> > There are actually a couple of places where I agree with the style
> > change, so I'll include that in a futher post after more useful
> review
> > has been posted (seriously, stylebots are just infuriating).
>
> So.. as irritating as you find the bot, there are a bunch of
> gratuitous style problems. In particular sungem.c itself isn't
> consistent about whether it has 8 char or 4 char indentation. That
> really does need to be fixed.
No time to work on this now. I will try to get back on to it later but
I'm happy for anybody to pick it up if they want to.
Cheers,
Ben.