qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result
Date: Wed, 21 Sep 2016 09:44:20 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0

On 09/21/2016 09:35 AM, Daniel P. Berrange wrote:

>> But I'm not sure if that suffices to meet GPL's requirements.
> 
> The compiler.h file has no license header, just a comment
> saying "public domain", which is obviously not the case
> if you add this macro.

Oh, I missed that; I was assuming compiler.h was GPLv2+ per the usual
project defaults; but that file is explicitly looser.

> 
> Given that you'll need to explicitly mention the license terms
> for ignore_value. eg with a comment line like
> 
>   /* The ignore_value() macro is taken from GNULIB ignore-value.h,
>    * licensed under the terms of the LGPLv2+
>    */

Yes, adding that solves any questions of origin.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]