qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/6] target-i386: Increase CPUID level/xlevel/xl


From: Eduardo Habkost
Subject: Re: [Qemu-devel] [PATCH 0/6] target-i386: Increase CPUID level/xlevel/xlevel2 automatically
Date: Wed, 21 Sep 2016 16:20:33 -0300
User-agent: Mutt/1.7.0 (2016-08-17)

On Wed, Sep 21, 2016 at 11:49:04AM -0700, address@hidden wrote:
> Hi,
> 
> Your series seems to have some coding style problems. See output below for
> more information:
> 
> Type: series
> Message-id: address@hidden
> Subject: [Qemu-devel] [PATCH 0/6] target-i386: Increase CPUID 
> level/xlevel/xlevel2 automatically

Oops! I have fixed the problems below in my local branch. The only remaining
warnings are:

/tmp/tmp.JqvmKcw0pK/0004-tests-Test-CPUID-level-handling-for-old-machines.patch 
has no obvious style problems and is ready for submission.
WARNING: line over 80 characters
#188: FILE: target-i386/cpu.c:3479:
+    DEFINE_PROP_UINT32("max-xlevel2", X86CPU, env.cpuid_max_xlevel2, 
UINT32_MAX),

WARNING: line over 80 characters
#189: FILE: target-i386/cpu.c:3480:
+    DEFINE_PROP_BOOL("cpuid-auto-level-7-0-ecx", X86CPU, 
cpuid_auto_level_7_0_ecx, true),

total: 0 errors, 2 warnings, 238 lines checked


> 
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
> 
> BASE=base
> n=1
> total=$(git log --oneline $BASE.. | wc -l)
> failed=0
> 
> # Useful git options
> git config --local diff.renamelimit 0
> git config --local diff.renames True
> 
> commits="$(git log --format=%H --reverse $BASE..)"
> for c in $commits; do
>     echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
>     if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; 
> then
>         failed=1
>         echo
>     fi
>     n=$((n+1))
> done
> 
> exit $failed
> === TEST SCRIPT END ===
> 
> Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
> From https://github.com/patchew-project/qemu
>  - [tag update]      patchew/address@hidden -> patchew/address@hidden
>  * [new tag]         patchew/address@hidden -> patchew/address@hidden
> Switched to a new branch 'test'
> cce6853 target-i386: Enable CPUID[0x8000000A] if SVM is enabled
> b0097d2 target-i386: Automatically set level/xlevel/xlevel2 when needed
> 8b47896 tests: Test CPUID level handling for old machines
> 5fcfd1b tests: Add test code for CPUID level/xlevel handling
> 32d3954 target-i386: Add a marker to end of the region zeroed on reset
> de76d02 target-i386: Remove unused X86CPUDefinition::xlevel2 field
> 
> === OUTPUT BEGIN ===
> Checking PATCH 1/6: target-i386: Remove unused X86CPUDefinition::xlevel2 
> field...
> Checking PATCH 2/6: target-i386: Add a marker to end of the region zeroed on 
> reset...
> Checking PATCH 3/6: tests: Add test code for CPUID level/xlevel handling...
> WARNING: line over 80 characters
> #113: FILE: tests/test-x86-cpuid-compat.c:76:
> +    add_cpuid_test("x86/cpuid/SandyBridge/level", "-cpu SandyBridge", 
> "level", 0xd);
> 
> WARNING: line over 80 characters
> #115: FILE: tests/test-x86-cpuid-compat.c:78:
> +    add_cpuid_test("x86/cpuid/core2duo/xlevel", "-cpu core2duo", "xlevel", 
> 0x80000008);
> 
> WARNING: line over 80 characters
> #116: FILE: tests/test-x86-cpuid-compat.c:79:
> +    add_cpuid_test("x86/cpuid/phenom/xlevel", "-cpu phenom", "xlevel", 
> 0x8000001A);
> 
> ERROR: line over 90 characters
> #120: FILE: tests/test-x86-cpuid-compat.c:83:
> +    add_cpuid_test("x86/cpuid/auto-level/phenom/fsgsbase", "-cpu 
> phenom,+fsgsbase", "level", 7);
> 
> ERROR: line over 90 characters
> #123: FILE: tests/test-x86-cpuid-compat.c:86:
> +    add_cpuid_test("x86/cpuid/auto-level/SandyBridge/multiple", "-cpu 
> SandyBridge,+arat,+fsgsbase,+avx512vbmi", "level", 0xd);
> 
> ERROR: line over 90 characters
> #126: FILE: tests/test-x86-cpuid-compat.c:89:
> +    add_cpuid_test("x86/cpuid/auto-xlevel/phenom/3dnow", "-cpu 
> phenom,+3dnow,+sse4a,+invtsc,+npt", "xlevel", 0x8000001A);
> 
> ERROR: line over 90 characters
> #129: FILE: tests/test-x86-cpuid-compat.c:92:
> +    add_cpuid_test("x86/cpuid/auto-xlevel2/486/fixed", "-cpu 
> 486,xlevel2=0xC0000002,+xstore", "xlevel2", 0xC0000002);
> 
> total: 4 errors, 3 warnings, 109 lines checked
> 
> Your patch has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 
> Checking PATCH 4/6: tests: Test CPUID level handling for old machines...
> ERROR: line over 90 characters
> #21: FILE: tests/test-x86-cpuid-compat.c:94:
> +    /* Compatibility test for older machine-types that don't auto-increase 
> level/xlevel/xlevel2: */
> 
> ERROR: line over 90 characters
> #23: FILE: tests/test-x86-cpuid-compat.c:96:
> +    add_cpuid_test("x86/cpuid/auto-level/pc-2.7", "-machine pc-i440fx-2.7 
> -cpu 486,+arat,+avx512vbmi,+xsaveopt", "level", 1);
> 
> ERROR: line over 90 characters
> #24: FILE: tests/test-x86-cpuid-compat.c:97:
> +    add_cpuid_test("x86/cpuid/auto-xlevel/pc-2.7", "-machine pc-i440fx-2.7 
> -cpu 486,+3dnow,+sse4a,+invtsc,+npt", "xlevel", 0);
> 
> ERROR: line over 90 characters
> #25: FILE: tests/test-x86-cpuid-compat.c:98:
> +    add_cpuid_test("x86/cpuid/auto-xlevel2/pc-2.7", "-machine pc-i440fx-2.7 
> -cpu 486,+xstore", "xlevel2", 0);
> 
> total: 4 errors, 0 warnings, 11 lines checked
> 
> Your patch has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 
> Checking PATCH 5/6: target-i386: Automatically set level/xlevel/xlevel2 when 
> needed...
> WARNING: line over 80 characters
> #69: FILE: target-i386/cpu.c:1647:
> +        env->cpuid_min_xlevel = kvm_arch_get_supported_cpuid(s, 0x80000000, 
> 0, R_EAX);
> 
> WARNING: line over 80 characters
> #70: FILE: target-i386/cpu.c:1648:
> +        env->cpuid_min_xlevel2 = kvm_arch_get_supported_cpuid(s, 0xC0000000, 
> 0, R_EAX);
> 
> ERROR: switch and case should be at the same indent
> #114: FILE: target-i386/cpu.c:2976:
> +    switch (region) {
> +        case 0x00000000:
> [...]
> +        case 0x80000000:
> [...]
> +        case 0xC0000000:
> 
> WARNING: line over 80 characters
> #177: FILE: target-i386/cpu.c:3476:
> +    DEFINE_PROP_UINT32("max-xlevel2", X86CPU, env.cpuid_max_xlevel2, 
> UINT32_MAX),
> 
> WARNING: line over 80 characters
> #178: FILE: target-i386/cpu.c:3477:
> +    DEFINE_PROP_BOOL("cpuid-auto-level-7-0-ecx", X86CPU, 
> cpuid_auto_level_7_0_ecx, true),
> 
> WARNING: line over 80 characters
> #225: FILE: tests/test-x86-cpuid-compat.c:83:
> +    add_cpuid_test("x86/cpuid/auto-level/phenom/arat", "-cpu 486,+arat", 
> "level", 6);
> 
> ERROR: line over 90 characters
> #229: FILE: tests/test-x86-cpuid-compat.c:87:
> +    add_cpuid_test("x86/cpuid/auto-level/phenom/avx512vbmi", "-cpu 
> phenom,+avx512vbmi", "level", 7);
> 
> ERROR: line over 90 characters
> #231: FILE: tests/test-x86-cpuid-compat.c:89:
> +    add_cpuid_test("x86/cpuid/auto-level/phenom/xsaveopt", "-cpu 
> phenom,+xsaveopt", "level", 0xd);
> 
> ERROR: line over 90 characters
> #233: FILE: tests/test-x86-cpuid-compat.c:91:
> +    add_cpuid_test("x86/cpuid/auto-xlevel/486/3dnow", "-cpu 486,+3dnow", 
> "xlevel", 0x80000001);
> 
> ERROR: line over 90 characters
> #235: FILE: tests/test-x86-cpuid-compat.c:93:
> +    add_cpuid_test("x86/cpuid/auto-xlevel/486/sse4a", "-cpu 486,+sse4a", 
> "xlevel", 0x80000001);
> 
> ERROR: line over 90 characters
> #237: FILE: tests/test-x86-cpuid-compat.c:95:
> +    add_cpuid_test("x86/cpuid/auto-xlevel/486/invtsc", "-cpu 486,+invtsc", 
> "xlevel", 0x80000007);
> 
> ERROR: line over 90 characters
> #239: FILE: tests/test-x86-cpuid-compat.c:97:
> +    add_cpuid_test("x86/cpuid/auto-xlevel/486/npt", "-cpu 486,+npt", 
> "xlevel", 0x8000000A);
> 
> ERROR: line over 90 characters
> #241: FILE: tests/test-x86-cpuid-compat.c:99:
> +    add_cpuid_test("x86/cpuid/auto-xlevel2/phenom/xstore", "-cpu 
> phenom,+xstore", "xlevel2", 0xC0000001);
> 
> ERROR: line over 90 characters
> #247: FILE: tests/test-x86-cpuid-compat.c:105:
> +    add_cpuid_test("x86/cpuid/auto-level/486/fixed/0xF", "-cpu 
> 486,level=0xF,+arat,+fsgsbase,+avx512vbmi,+xsaveopt", "level", 0xF);
> 
> ERROR: line over 90 characters
> #248: FILE: tests/test-x86-cpuid-compat.c:106:
> +    add_cpuid_test("x86/cpuid/auto-level/486/fixed/2", "-cpu 
> 486,level=2,+arat,+fsgsbase,+avx512vbmi,+xsaveopt", "level", 2);
> 
> ERROR: line over 90 characters
> #253: FILE: tests/test-x86-cpuid-compat.c:111:
> +    add_cpuid_test("x86/cpuid/auto-xlevel/486/fixed/80000002", "-cpu 
> 486,xlevel=0x80000002,+3dnow,+sse4a,+invtsc,+npt", "xlevel", 0x80000002);
> 
> ERROR: line over 90 characters
> #254: FILE: tests/test-x86-cpuid-compat.c:112:
> +    add_cpuid_test("x86/cpuid/auto-xlevel/486/fixed/8000001A", "-cpu 
> 486,xlevel=0x8000001A,+3dnow,+sse4a,+invtsc,+npt", "xlevel", 0x8000001A);
> 
> total: 12 errors, 5 warnings, 214 lines checked
> 
> Your patch has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 
> Checking PATCH 6/6: target-i386: Enable CPUID[0x8000000A] if SVM is enabled...
> WARNING: line over 80 characters
> #38: FILE: tests/test-x86-cpuid-compat.c:80:
> +    add_cpuid_test("x86/cpuid/athlon/xlevel", "-cpu athlon", "xlevel", 
> 0x80000008);
> 
> ERROR: line over 90 characters
> #47: FILE: tests/test-x86-cpuid-compat.c:102:
> +    add_cpuid_test("x86/cpuid/auto-xlevel/athlon/svm", "-cpu athlon,+svm", 
> "xlevel", 0x8000000A);
> 
> ERROR: line over 90 characters
> #56: FILE: tests/test-x86-cpuid-compat.c:112:
> +    add_cpuid_test("x86/cpuid/auto-xlevel/phenom/3dnow", "-cpu 
> phenom,+3dnow,+sse4a,+invtsc,+npt,+svm", "xlevel", 0x8000001A);
> 
> ERROR: line over 90 characters
> #60: FILE: tests/test-x86-cpuid-compat.c:114:
> +    add_cpuid_test("x86/cpuid/auto-xlevel/486/fixed/80000002", "-cpu 
> 486,xlevel=0x80000002,+3dnow,+sse4a,+invtsc,+npt,+svm", "xlevel", 0x80000002);
> 
> ERROR: line over 90 characters
> #61: FILE: tests/test-x86-cpuid-compat.c:115:
> +    add_cpuid_test("x86/cpuid/auto-xlevel/486/fixed/8000001A", "-cpu 
> 486,xlevel=0x8000001A,+3dnow,+sse4a,+invtsc,+npt,+svm", "xlevel", 0x8000001A);
> 
> ERROR: line over 90 characters
> #70: FILE: tests/test-x86-cpuid-compat.c:123:
> +    add_cpuid_test("x86/cpuid/auto-xlevel/pc-2.7", "-machine pc-i440fx-2.7 
> -cpu 486,+3dnow,+sse4a,+invtsc,+npt,+svm", "xlevel", 0);
> 
> total: 5 errors, 1 warnings, 48 lines checked
> 
> Your patch has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 
> === OUTPUT END ===
> 
> Test command exited with code: 1
> 
> 
> ---
> Email generated automatically by Patchew [http://patchew.org/].
> Please send your feedback to address@hidden

-- 
Eduardo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]