Re: [Qemu-devel] [PATCH 15/30] qmp-commands: move 'query-migrate-parameters' doc to schema

[Eric Blake]

On 09/13/2016 08:01 AM, Marc-André Lureau wrote:
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
>  docs/qmp-commands.txt | 29 -----------------------------
>  qapi-schema.json      | 13 +++++++++++++
>  2 files changed, 13 insertions(+), 29 deletions(-)
> 

> +++ b/qapi-schema.json
> @@ -1011,6 +1011,19 @@
>  # Returns: @MigrationParameters
>  #
>  # Since: 2.4
> +#
> +# Example:
> +#
> +# -> { "execute": "query-migrate-parameters" }
> +# <- { "return": {
> +#          "decompress-threads": 2,
> +#          "cpu-throttle-increment": 10,
> +#          "compress-threads": 8,
> +#          "compress-level": 1,
> +#          "cpu-throttle-initial": 20
> +#       }
> +#    }
> +#
>  ##
>  { 'command': 'query-migrate-parameters',
>    'returns': 'MigrationParameters' }

The example lacks 'cpu-throttle-increment', 'tls-creds', and
'tls-hostname'; do we want to take this opportunity to touch it up?
Meanwhile, I have a series that touches this code, and will obviously
create a merge conflict for whoever gets in second:

https://lists.gnu.org/archive/html/qemu-devel/2016-09/msg01946.html

At any rate, 11-15 are
Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature