qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 2/4] qapi: assert list entry has a value


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v2 2/4] qapi: assert list entry has a value
Date: Wed, 21 Sep 2016 16:06:41 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0

On 09/21/2016 03:10 PM, Marc-André Lureau wrote:
> This helps to figure out the expectations.
> 
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
>  qapi/qmp-input-visitor.c | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Eric Blake <address@hidden>

> 
> diff --git a/qapi/qmp-input-visitor.c b/qapi/qmp-input-visitor.c
> index be52aaf..c1019d6 100644
> --- a/qapi/qmp-input-visitor.c
> +++ b/qapi/qmp-input-visitor.c
> @@ -84,6 +84,7 @@ static QObject *qmp_input_get_object(QmpInputVisitor *qiv,
>          assert(qobject_type(qobj) == QTYPE_QLIST);
>          assert(!name);
>          ret = qlist_entry_obj(tos->entry);
> +        assert(ret);
>          if (consume) {
>              tos->entry = qlist_next(tos->entry);
>          }
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]