Re: [Qemu-devel] [PATCH v3] scripts: Add a script to check for bug URLs in the git log

[Thomas Huth]

On Wed, 21 Sep 2016 22:08:10 +0200
Paolo Bonzini <address@hidden> wrote:

> On 21/09/2016 21:42, Thomas Huth wrote:
> > Basic idea of this script is to check the git log for URLs
> > to the QEMU bugtracker at launchpad.net and to figure out
> > whether the related bug has been marked there as "Fix released"
> > (i.e. closed) already. So this script can e.g. be used after
> > each public release of QEMU to check whether there are any
> > bug tickets that could be moved from "Fix committed" (or another
> > state if the author of the patch forgot to update the bug ticket)
> > to "Fix released".
> > 
> > Signed-off-by: Thomas Huth <address@hidden>
> > ---
> >  v3: Adressed Eric's review comments from v2 (fixed bashisms, more
> >      POSIX compliance, use lower-case variable names, etc.)
> 
> Queued with this squashed in:

Thanks a lot for the fixup. But...

> diff --git a/scripts/show-fixed-bugs.sh b/scripts/show-fixed-bugs.sh
> index 9dcc0f7..6e64edd 100755
> --- a/scripts/show-fixed-bugs.sh
> +++ b/scripts/show-fixed-bugs.sh
> @@ -23,7 +23,7 @@ while getopts "s:e:cbh" opt; do
>  done
>  
>  if [ "x$start" = "x" ]; then
> -    start=`git tag -l 'v[0-9]*\.[0-9]*.0' | tail -n 2 | head -n 1`
> +    start=`git tag -l 'v[0-9]*\.[0-9]*\.0' | tail -n 2 | head -n 1`
>  fi
>  if [ "x$end" = "x" ]; then
>      end=`git tag -l  'v[0-9]*\.[0-9]*.0' | tail -n 1`

... could you please also squash in another backslash in the "end=..."
line here?

Thanks,
 Thomas