qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH qemu v2] tap: Allow specifying a bridge


From: Jason Wang
Subject: Re: [Qemu-devel] [PATCH qemu v2] tap: Allow specifying a bridge
Date: Thu, 22 Sep 2016 15:03:28 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0



On 2016年09月14日 23:12, Eric Blake wrote:
On 09/14/2016 09:17 AM, Greg Kurz wrote:
On Tue, 13 Sep 2016 17:11:54 +1000
Alexey Kardashevskiy <address@hidden> wrote:

The tap backend is already using qemu-bridge-helper to attach tap
interface to a bridge but (unlike the bridge backend) it always uses
the default bridge name - br0.

This adds a "br" property support to the tap backend.

Signed-off-by: Alexey Kardashevskiy <address@hidden>
--
Cool ! This allows to easily attach to virbr0 :)

Now that a consensus seems to have been reached for @br:
Yes, but there was still my other comment that:


+++ b/qapi-schema.json
@@ -2575,6 +2575,8 @@
  #
  # @downscript: #optional script to shut down the interface
  #
+# @br: #optional bridge name
this is missing a '(since 2.8)' designator.  Perhaps the maintainer can
supply it without needing a v3.


Adding "since 2.8" and applied.

Thanks



reply via email to

[Prev in Thread] Current Thread [Next in Thread]