Re: [Qemu-devel] [PATCH] checkpatch: downgrade "architecture specific defines should be avoided"

[Markus Armbruster]

Paolo Bonzini <address@hidden> writes:

> ---
>  scripts/checkpatch.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index dde3f5f..3afa19a 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2407,7 +2407,7 @@ sub process {
>  # we have e.g. CONFIG_LINUX and CONFIG_WIN32 for common cases
>  # where they might be necessary.
>               if ($line =~ address@hidden@) {
> -                     ERROR("architecture specific defines should be 
> avoided\n" .  $herecurr);
> +                     WARN("architecture specific defines should be 
> avoided\n" .  $herecurr);
>               }
>  
>  # Check that the storage class is at the beginning of a declaration

git-grep finds almost 400 of them.  We certainly want people to think
twice (or thrice) before they add more.  The question to discuss here is
whether we want to force that thinking onto the list.  If yes, keep
ERROR.  If no, downgrade to warn.