[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 4/9] virtio: handle virtqueue_map_desc() erro
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-devel] [PATCH v5 4/9] virtio: handle virtqueue_map_desc() errors |
Date: |
Thu, 22 Sep 2016 15:49:43 +0200 |
On Wed, 21 Sep 2016 16:52:21 +0100
Stefan Hajnoczi <address@hidden> wrote:
> Errors can occur during virtqueue_pop(), especially in
> virtqueue_map_desc(). In order to handle this we must unmap iov[]
> before returning NULL. The caller will consider the virtqueue empty and
> the virtio_error() call will have marked the device broken.
>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
> hw/virtio/virtio.c | 74
> ++++++++++++++++++++++++++++++++++++++++--------------
> 1 file changed, 55 insertions(+), 19 deletions(-)
Reviewed-by: Cornelia Huck <address@hidden>
- [Qemu-devel] [PATCH v5 0/9] virtio: avoid exit() when device enters invalid states, Stefan Hajnoczi, 2016/09/21
- [Qemu-devel] [PATCH v5 2/9] virtio: stop virtqueue processing if device is broken, Stefan Hajnoczi, 2016/09/21
- [Qemu-devel] [PATCH v5 1/9] virtio: fix stray tab character, Stefan Hajnoczi, 2016/09/21
- [Qemu-devel] [PATCH v5 3/9] virtio: migrate vdev->broken flag, Stefan Hajnoczi, 2016/09/21
- [Qemu-devel] [PATCH v5 4/9] virtio: handle virtqueue_map_desc() errors, Stefan Hajnoczi, 2016/09/21
- Re: [Qemu-devel] [PATCH v5 4/9] virtio: handle virtqueue_map_desc() errors,
Cornelia Huck <=
- [Qemu-devel] [PATCH v5 5/9] virtio: handle virtqueue_get_avail_bytes() errors, Stefan Hajnoczi, 2016/09/21
- [Qemu-devel] [PATCH v5 6/9] virtio: use unsigned int for virtqueue_get_avail_bytes() index, Stefan Hajnoczi, 2016/09/21
- [Qemu-devel] [PATCH v5 7/9] virtio: handle virtqueue_read_next_desc() errors, Stefan Hajnoczi, 2016/09/21
- [Qemu-devel] [PATCH v5 8/9] virtio: handle virtqueue_num_heads() errors, Stefan Hajnoczi, 2016/09/21
- [Qemu-devel] [PATCH v5 9/9] virtio: handle virtqueue_get_head() errors, Stefan Hajnoczi, 2016/09/21