Re: [Qemu-devel] [RFC PATCH v2 00/16] x86: Secure Encrypted Virtualization (AMD)

[no-reply]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [RFC PATCH v2 00/16] x86: Secure Encrypted Virtualization 
(AMD)

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
850cc25 i386: clear C-bit in SEV guest page table walk
118801a target-i386: add cpuid Fn8000_001f
0a1150c i386: set memory encryption ops for PC.BIOS and PC.RAM regions
cc8e566 sev: add DEBUG_ENCRYPT command
7a078d0 sev: add DEBUG_DECRYPT command
86d0fa9 sev: add LAUNCH_FINISH command
2fab8c2 sev: add LAUNCH_UPDATE command
1786fb6 sev: add LAUNCH_START command
0b20533 core: loader: create memory encryption context before copying data
9d4475b hmp: display memory encryption support in 'info kvm'
a3a62fd sev: add Secure Encrypted Virtulization (SEV) support
405efda core: add new security-policy object
3d2db73 monitor: use debug version of memory access apis
bcb1584 exec: add debug version of physical memory read and write apis
ef720ae exec: add guest RAM read and write ops
bcdc107 memattrs: add debug attrs

=== OUTPUT BEGIN ===
Checking PATCH 1/16: memattrs: add debug attrs...
Checking PATCH 2/16: exec: add guest RAM read and write ops...
Checking PATCH 3/16: exec: add debug version of physical memory read and write 
apis...
Checking PATCH 4/16: monitor: use debug version of memory access apis...
Checking PATCH 5/16: core: add new security-policy object...
Checking PATCH 6/16: sev: add Secure Encrypted Virtulization (SEV) support...
ERROR: trailing whitespace
#705: FILE: qemu-options.hx:4000:
+SEV-enabled guest. $

ERROR: do not use C99 // comments
#1736: FILE: sev.c:923:
+    // add the command to launch guest in next patches

ERROR: do not use C99 // comments
#1743: FILE: sev.c:930:
+    // add the command to finalize the launch in next patches

ERROR: do not use C99 // comments
#1810: FILE: sev.c:997:
+        // use receive_info commands

ERROR: do not use C99 // comments
#1827: FILE: sev.c:1014:
+        // use launch_finish commands

ERROR: do not use C99 // comments
#1829: FILE: sev.c:1016:
+        // use receive_finish commands

ERROR: do not use C99 // comments
#1844: FILE: sev.c:1031:
+    // fill in the code in next patches

ERROR: do not use C99 // comments
#1855: FILE: sev.c:1042:
+    // fill in the code in next patches

total: 8 errors, 0 warnings, 1775 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 7/16: hmp: display memory encryption support in 'info kvm'...
Checking PATCH 8/16: core: loader: create memory encryption context before 
copying data...
Checking PATCH 9/16: sev: add LAUNCH_START command...
Checking PATCH 10/16: sev: add LAUNCH_UPDATE command...
Checking PATCH 11/16: sev: add LAUNCH_FINISH command...
Checking PATCH 12/16: sev: add DEBUG_DECRYPT command...
Checking PATCH 13/16: sev: add DEBUG_ENCRYPT command...
Checking PATCH 14/16: i386: set memory encryption ops for PC.BIOS and PC.RAM 
regions...
Checking PATCH 15/16: target-i386: add cpuid Fn8000_001f...
Checking PATCH 16/16: i386: clear C-bit in SEV guest page table walk...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden