Re: [Qemu-devel] [PATCH v2 5/5] vmstateify tsc210x

[Peter Maydell]

On 24 August 2016 at 11:40, Dr. David Alan Gilbert (git)
<address@hidden> wrote:
> From: "Dr. David Alan Gilbert" <address@hidden>
>
> Note:
>   I know nothing about this hardware.
>
>   I'm now saving all 3 of the pll entries; only 2 were saved before.
>   There are a couple of times that were previously stored as offsets
>    from 'now' calculated before saving;  with vmstate it's easier
>   to store the 'now' and fix it up on reload.
>
> Signed-off-by: Dr. David Alan Gilbert <address@hidden>
> ---
>  hw/input/tsc210x.c | 197 
> ++++++++++++++++++++++++-----------------------------
>  1 file changed, 89 insertions(+), 108 deletions(-)

This one looks ok, other than the same comments as for 4/5.

thanks
-- PMM