Re: [Qemu-devel] [PATCH v4 01/17] trace: add trace event iterator APIs

[Stefan Hajnoczi]

On Thu, Sep 22, 2016 at 09:40:36AM +0100, Daniel P. Berrange wrote:
> Currently methods which want to iterate over trace events,
> do so using the trace_event_count() and trace_event_id()
> methods. This leaks the concept of a single ID enum to
> the callers. There is an alternative trace_event_pattern()
> method which can be used in an iteration context, but its
> design is stateless, so is not easy to expand it in the
> future.
> 
> This defines a formal iterator API will provide a future-
> proof way of iterating over events.
> 
> The iterator is also able to apply a pattern match filter
> to events, further removing the need for the pattern
> 
> Reviewed-by: Lluís Vilanova <address@hidden>
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
>  trace/control.c | 21 +++++++++++++++++++++
>  trace/control.h | 27 +++++++++++++++++++++++++++
>  2 files changed, 48 insertions(+)

Reviewed-by: Stefan Hajnoczi <address@hidden>

signature.asc
Description: PGP signature