|
From: | Richard Henderson |
Subject: | Re: [Qemu-devel] [PATCH 16/16] cpus-common: lock-free fast path for cpu_exec_start/end |
Date: | Fri, 23 Sep 2016 11:23:46 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 |
On 09/23/2016 12:31 AM, Paolo Bonzini wrote:
+ if (atomic_read(&other_cpu->running)) {
...
+ atomic_set(&cpu->running, true);
...
+ cpu->running = false;
...
+ cpu->running = true;
Inconsistent use of atomics. I don't see that the cpu_list_lock protects the last two lines in any way.
r~
[Prev in Thread] | Current Thread | [Next in Thread] |