[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 4/7] target-i386: xsave: Simplify CPUID[0xD, 0].{EAX
From: |
Eduardo Habkost |
Subject: |
[Qemu-devel] [PATCH 4/7] target-i386: xsave: Simplify CPUID[0xD, 0].{EAX, EDX} calculation |
Date: |
Fri, 23 Sep 2016 16:45:33 -0300 |
Instead of assigning individual bits in a loop, just copy the
values from ena_mask.
Signed-off-by: Eduardo Habkost <address@hidden>
---
target-i386/cpu.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 9968581..7e66003 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -2523,15 +2523,11 @@ void cpu_x86_cpuid(CPUX86State *env, uint32_t index,
uint32_t count,
for (i = 2; i < ARRAY_SIZE(x86_ext_save_areas); i++) {
const ExtSaveArea *esa = &x86_ext_save_areas[i];
if ((ena_mask >> i) & 1) {
- if (i < 32) {
- *eax |= 1u << i;
- } else {
- *edx |= 1u << (i - 32);
- }
*ecx = MAX(*ecx, esa->offset + esa->size);
}
}
- *eax |= ena_mask & (XSTATE_FP_MASK | XSTATE_SSE_MASK);
+ *eax = ena_mask;
+ *edx = ena_mask >> 32;
*ebx = *ecx;
} else if (count == 1) {
*eax = env->features[FEAT_XSAVE];
--
2.7.4
- [Qemu-devel] [PATCH 0/7] target-i386: xsave CPUID handling refactor, Eduardo Habkost, 2016/09/23
- [Qemu-devel] [PATCH 1/7] target-i386: Move feature name arrays inside FeatureWordInfo, Eduardo Habkost, 2016/09/23
- [Qemu-devel] [PATCH 2/7] target-i386: Don't try to enable PT State xsave component, Eduardo Habkost, 2016/09/23
- [Qemu-devel] [PATCH 3/7] target-i386: xsave: Calculate enabled components only once, Eduardo Habkost, 2016/09/23
- [Qemu-devel] [PATCH 4/7] target-i386: xsave: Simplify CPUID[0xD, 0].{EAX, EDX} calculation,
Eduardo Habkost <=
- [Qemu-devel] [PATCH 6/7] target-i386: xsave: Calculate set of xsave components on realize, Eduardo Habkost, 2016/09/23
- [Qemu-devel] [PATCH 5/7] target-i386: xsave: Helper function to calculate xsave area size, Eduardo Habkost, 2016/09/23
- [Qemu-devel] [PATCH 7/7] target-i386: Move xsave component mask to features array, Eduardo Habkost, 2016/09/23
- Re: [Qemu-devel] [PATCH 0/7] target-i386: xsave CPUID handling refactor, Eduardo Habkost, 2016/09/27