Re: [Qemu-devel] [PULL 00/19] virtio, pc: fixes and features

[no-reply]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PULL 00/19] virtio, pc: fixes and features

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
cacc4b0 hw/i386: AMD IOMMU IVRS table
9dd76e8 hw/i386: Introduce AMD IOMMU
51d6513 hw/i386/trace-events: Add AMD IOMMU trace events
2897b28 hw/pci: Prepare for AMD IOMMU
9ed4ac9 virtio: handle virtqueue_get_head() errors
eba15c9 virtio: handle virtqueue_num_heads() errors
3c5513c virtio: handle virtqueue_read_next_desc() errors
3e2dd44 virtio: use unsigned int for virtqueue_get_avail_bytes() index
b63060b virtio: handle virtqueue_get_avail_bytes() errors
a7e238f virtio: handle virtqueue_map_desc() errors
b1ee7b9 virtio: migrate vdev->broken flag
5ae212e virtio: stop virtqueue processing if device is broken
7add352 virtio: fix stray tab character
a8b4e23 target-i386: turn off CPU.l3-cache only for 2.7 and older machine types
eb0f9de pc: clean up COMPAT macro chaining
f2df3c1 virtio: add check for descriptor's mapped address
f2997b7 tests: add /vhost-user/flags-mismatch test
b612c50 tests: add a simple /vhost-user/multiqueue test
c38be03 tests: add /vhost-user/connect-fail test

=== OUTPUT BEGIN ===
Checking PATCH 1/19: tests: add /vhost-user/connect-fail test...
Checking PATCH 2/19: tests: add a simple /vhost-user/multiqueue test...
WARNING: line over 80 characters
#192: FILE: tests/vhost-user-test.c:824:
+    cmd = g_strdup_printf(QEMU_CMD_MEM QEMU_CMD_CHR QEMU_CMD_NETDEV 
",queues=%d "

total: 0 errors, 1 warnings, 198 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 3/19: tests: add /vhost-user/flags-mismatch test...
Checking PATCH 4/19: virtio: add check for descriptor's mapped address...
Checking PATCH 5/19: pc: clean up COMPAT macro chaining...
Checking PATCH 6/19: target-i386: turn off CPU.l3-cache only for 2.7 and older 
machine types...
Checking PATCH 7/19: virtio: fix stray tab character...
Checking PATCH 8/19: virtio: stop virtqueue processing if device is broken...
Checking PATCH 9/19: virtio: migrate vdev->broken flag...
Checking PATCH 10/19: virtio: handle virtqueue_map_desc() errors...
Checking PATCH 11/19: virtio: handle virtqueue_get_avail_bytes() errors...
Checking PATCH 12/19: virtio: use unsigned int for virtqueue_get_avail_bytes() 
index...
Checking PATCH 13/19: virtio: handle virtqueue_read_next_desc() errors...
Checking PATCH 14/19: virtio: handle virtqueue_num_heads() errors...
Checking PATCH 15/19: virtio: handle virtqueue_get_head() errors...
Checking PATCH 16/19: hw/pci: Prepare for AMD IOMMU...
Checking PATCH 17/19: hw/i386/trace-events: Add AMD IOMMU trace events...
Checking PATCH 18/19: hw/i386: Introduce AMD IOMMU...
ERROR: struct MemoryRegionIOMMUOps should normally be const
#1527: FILE: hw/i386/amd_iommu.h:280:
+    MemoryRegionIOMMUOps iommu_ops;

total: 1 errors, 0 warnings, 1495 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 19/19: hw/i386: AMD IOMMU IVRS table...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden