[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 00/19] virtio, pc: fixes and features
|
From: |
Michael S. Tsirkin |
|
Subject: |
Re: [Qemu-devel] [PULL 00/19] virtio, pc: fixes and features |
|
Date: |
Sun, 25 Sep 2016 03:49:13 +0300 |
On Sat, Sep 24, 2016 at 06:10:37PM +0200, Paolo Bonzini wrote:
>
>
> On 24/09/2016 00:05, Michael S. Tsirkin wrote:
> >> e events...
> >> > Checking PATCH 18/19: hw/i386: Introduce AMD IOMMU...
> >> > ERROR: struct MemoryRegionIOMMUOps should normally be const
> >> > #1527: FILE: hw/i386/amd_iommu.h:280:
> >> > + MemoryRegionIOMMUOps iommu_ops;
> >
> > False positive.
>
> Not quite, there's no reason for the ops to be inside AMDVIState rather
> than a (static) global.
>
> Paolo
I guess but it's a logic refactoring, not merely a style one.
I feel we can do it on top, tool shouldn't require this.
- [Qemu-devel] [PULL 13/19] virtio: handle virtqueue_read_next_desc() errors, (continued)
- [Qemu-devel] [PULL 13/19] virtio: handle virtqueue_read_next_desc() errors, Michael S. Tsirkin, 2016/09/23
- [Qemu-devel] [PULL 16/19] hw/pci: Prepare for AMD IOMMU, Michael S. Tsirkin, 2016/09/23
- [Qemu-devel] [PULL 17/19] hw/i386/trace-events: Add AMD IOMMU trace events, Michael S. Tsirkin, 2016/09/23
- [Qemu-devel] [PULL 19/19] hw/i386: AMD IOMMU IVRS table, Michael S. Tsirkin, 2016/09/23
- [Qemu-devel] [PULL 18/19] hw/i386: Introduce AMD IOMMU, Michael S. Tsirkin, 2016/09/23
- Re: [Qemu-devel] [PULL 00/19] virtio, pc: fixes and features, no-reply, 2016/09/23
- Re: [Qemu-devel] [PULL 00/19] virtio, pc: fixes and features, no-reply, 2016/09/23