Re: [Qemu-devel] [PATCH v2 0/3] crypto: add ctr mode support and little inprovement

[Daniel P. Berrange]

On Sat, Sep 24, 2016 at 02:29:16AM +0000, Gonglei (Arei) wrote:
> 
> 
> > -----Original Message-----
> > From: address@hidden [mailto:address@hidden
> > Sent: Saturday, September 24, 2016 10:22 AM
> > To: Gonglei (Arei)
> > Cc: address@hidden; address@hidden; Gonglei (Arei); Wubin (H)
> > Subject: Re: [Qemu-devel] [PATCH v2 0/3] crypto: add ctr mode support and
> > little inprovement
> > 
> > Hi,
> > 
> > Your series failed automatic build test. Please find the testing commands 
> > and
> > their output below. If you have docker installed, you can probably 
> > reproduce it
> > locally.
> > 

> > GTESTER tests/test-crypto-cipher
> > GTESTER tests/test-crypto-secret
> > **
> > ERROR:/tmp/qemu-test/src/tests/test-crypto-cipher.c:528:test_cipher:
> > assertion failed: (err == NULL)
> > Unexpected error in qcrypto_cipher_new() at
> > /tmp/qemu-test/src/crypto/cipher-builtin.c:442:
> > Unsupported cipher mode cbc
> > GTester: last random seed: R02S728541368fda15b567d6152f14684330
> > GTester: last random seed: R02S03fa5a3e38035a395de344b8486a8d96
> > **
> > ERROR:/tmp/qemu-test/src/tests/test-crypto-cipher.c:528:test_cipher:
> > assertion failed: (err == NULL)
> > Unexpected error in qcrypto_cipher_new() at
> > /tmp/qemu-test/src/crypto/cipher-builtin.c:442:
> > Unsupported cipher mode cbc
> > GTester: last random seed: R02Sa1d40c315665a972d0077ab62786a4a9
> > GTester: last random seed: R02Sd6a1af04334fbd0a715b89b4c4770e2e
> > **
> > ERROR:/tmp/qemu-test/src/tests/test-crypto-cipher.c:528:test_cipher:
> > assertion failed: (err == NULL)
> > make: *** [check-tests/test-crypto-secret] Error 1
> > make: *** Waiting for unfinished jobs....
> > GTester: last random seed: R02S8309a8b2773c5611f6b2da378e7a76fb
> > **
> > ERROR:/tmp/qemu-test/src/tests/test-crypto-cipher.c:528:test_cipher:
> > assertion failed: (err == NULL)
> > GTester: last random seed: R02Safb17e9ffefc1c5c3e45211d6509b7d0
> > **
> > ERROR:/tmp/qemu-test/src/tests/test-crypto-cipher.c:528:test_cipher:
> > assertion failed: (err == NULL)
> > GTester: last random seed: R02S770f50b2a35e94c39875d1aee5da7371
> > **
> > ERROR:/tmp/qemu-test/src/tests/test-crypto-cipher.c:528:test_cipher:
> > assertion failed: (err == NULL)
> > GTester: last random seed: R02S3ee10e29160387b498cf0e181611c0fc
> > **
> > ERROR:/tmp/qemu-test/src/tests/test-crypto-cipher.c:528:test_cipher:
> > assertion failed: (err == NULL)
> > GTester: last random seed: R02S11f675b1e67013a797f4b6eabacf4e53
> > **
> > ERROR:/tmp/qemu-test/src/tests/test-crypto-cipher.c:528:test_cipher:
> > assertion failed: (err == NULL)
> > GTester: last random seed: R02S850eea2a24a4ee7f9ec2a8d8fc5aa91c
> > **
> > ERROR:/tmp/qemu-test/src/tests/test-crypto-cipher.c:528:test_cipher:
> > assertion failed: (err == NULL)
> > GTester: last random seed: R02S437d1a4318a6aeb4a49d62fb22e8fc95
> > **
> > ERROR:/tmp/qemu-test/src/tests/test-crypto-cipher.c:528:test_cipher:
> > assertion failed: (err == NULL)
> > GTester: last random seed: R02S7184a8a8cd35b2faade67bee6ba6e241
> > **
> > ERROR:/tmp/qemu-test/src/tests/test-crypto-cipher.c:528:test_cipher:
> > assertion failed: (err == NULL)
> > GTester: last random seed: R02Sb0f61d1d0330a6c210a76f0caa25f991
> > Unexpected error in qcrypto_cipher_new() at
> > /tmp/qemu-test/src/crypto/cipher-builtin.c:442:
> > Unsupported cipher mode cbc
> > GTester: last random seed: R02S94f3d34298a0e4548a72dfce873f2362
> > Unexpected error in qcrypto_cipher_new() at
> > /tmp/qemu-test/src/crypto/cipher-builtin.c:442:
> > Unsupported cipher mode cbc
> > GTester: last random seed: R02S38bab4972cc5f7d592fecf71ba1705b4
> > make: *** [check-tests/test-crypto-cipher] Error 1
> > tests/docker/Makefile.include:107: recipe for target
> > 'address@hidden' failed
> > make: *** address@hidden Error 2
> > === OUTPUT END ===
> > 
> > Test command exited with code: 2
> > 
> It is fixed by Patch 2 in the same patch serials.

It is broken by patch 3 though

When you re-send, can you put patch 1 after patch 2, so that the series
is friendly to git bisect

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|