qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 0/3] object: Add 'help' option for all availa


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH v3 0/3] object: Add 'help' option for all available backends and properties
Date: Mon, 26 Sep 2016 12:39:33 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0


On 26/09/2016 12:16, Lin Ma wrote:
> Print available object backend types and the relevant properties.
> 
> V2->v3:
> * make type user-creatable abstract.
> * auto generate enum value strings during qemu configuration.(Borrowwed 
> Daniel's code)
> * save the generated enum value strings into member description of 
> ObjectProperty.

Frankly, I don't think this is useful.  At some point you need to look
at some bigger manual than just the program help.

However, emitting the description of the property is useful.

Paolo

> * drop the judgement logic of whether a property has an enumeration type 
> anymore,
>   output member description of ObjectProperty directly.
> * at least, user_creatable_help_func should be put after
>   'object_property_add_child(object_get_root(), 
> "machine",OBJECT(current_machine), ...)',
>   because host_memory_backend_init needs to access an instance of type 
> machine.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]