qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PULL 17/33] block: Accept device model name for x-bloc


From: Kevin Wolf
Subject: Re: [Qemu-devel] [PULL 17/33] block: Accept device model name for x-blockdev-remove-medium
Date: Mon, 26 Sep 2016 15:08:09 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

Am 26.09.2016 um 12:59 hat Paolo Bonzini geschrieben:
> On 22/09/2016 18:29, Kevin Wolf wrote:
> > -    qmp_x_blockdev_remove_medium(device, &err);
> > +    qmp_x_blockdev_remove_medium(true, device, false, NULL, errp);
> >      if (err) {
> >          error_propagate(errp, err);
> >          goto fail;
> 
> Bug: &err changed to errp, so err is always NULL.

&err vs. errp is kind of hard to spot in a diff. Maybe a good reason to
stick with "local_err" rather than "err" where we introduce new local
error variables.

Anyway, patch sent.

Kevin



reply via email to

[Prev in Thread] Current Thread [Next in Thread]