Re: [Qemu-devel] [Qemu-block] [PATCH 0/1] ahci: fix ncq aiocb-related segfault

[John Snow]

On 09/26/2016 12:10 PM, Stefan Hajnoczi wrote:
> On Thu, Sep 22, 2016 at 04:10:39PM -0400, John Snow wrote:
> > Fix ncq_cb to prevent a segfault on sys_reset.
> >
> > John Snow (1):
> >   ahci: clear aiocb in ncq_cb
> >
> >  hw/ide/ahci.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > --
> > 2.7.4
>
> Maybe worth adding as a clarification:
>
> The issue is when bdrv_aio_cancel() is called after ncq_cb() was already
> invoked.  The aiocb will be a dangling pointer.

Done.

> Reviewed-by: Stefan Hajnoczi <address@hidden>

Thanks, applied to my IDE tree:

https://github.com/jnsnow/qemu/commits/ide
https://github.com/jnsnow/qemu.git

--js