Re: [Qemu-devel] [PATCH 2/3] virtio-blk: add missing virtio_detach_element() call

[Greg Kurz]

On Tue, 27 Sep 2016 09:49:17 +0200
Ladi Prosek <address@hidden> wrote:

> On Mon, Sep 19, 2016 at 3:28 PM, Stefan Hajnoczi <address@hidden> wrote:
> > Make sure to unmap the scatter-gather list and decrement vq->inuse
> > before freeing requests in virtio_blk_reset().
> >
> > Signed-off-by: Stefan Hajnoczi <address@hidden>
> > ---
> >  hw/block/virtio-blk.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
> > index 3a6112f..c7ca4d6 100644
> > --- a/hw/block/virtio-blk.c
> > +++ b/hw/block/virtio-blk.c
> > @@ -665,6 +665,7 @@ static void virtio_blk_reset(VirtIODevice *vdev)
> >      while (s->rq) {
> >          req = s->rq;
> >          s->rq = req->next;
> > +        virtqueue_detach_element(req->vq, &req->elem, 0);
> >          virtio_blk_free_request(req);  
> 
> Random observation. virtio_blk_free_request should be static and
> removed from the header file. 

I've sent a followup patch for this:

<address@hidden>

> Or maybe removed altogether because g_free takes NULL pointers just fine.
> 

virtio_blk_free_request() does not seem useful indeed... :)

Cheers.

--
Greg

> >      }
> >
> > --
> > 2.7.4
> >  
> 
> Reviewed-by: Ladi Prosek <address@hidden>
> 
> Thanks!
>