qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/2] xen: add qemu device for each pvusb backend


From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH 2/2] xen: add qemu device for each pvusb backend
Date: Tue, 27 Sep 2016 11:08:29 +0200

  Hi,

>  struct usbback_info {
>      struct XenDevice         xendev;  /* must be first */
> +    char                     id[24];
> +    struct USBBACKDevice     *dev;
>      USBBus                   bus;
>      void                     *urb_sring;
>      void                     *conn_sring;
> @@ -116,6 +124,10 @@ struct usbback_info {
>      QEMUBH                   *bh;
>  };
>  
> +typedef struct USBBACKDevice {
> +    DeviceState qdev;
> +} USBBACKDevice;

Hmm, I think the xen core needs better QOM support ...

struct XenDevice should have a DeviceState element, so it can be used as
device object directly instead of attaching a device object like
this ...

cheers,
  Gerd




reply via email to

[Prev in Thread] Current Thread [Next in Thread]