Re: [Qemu-devel] [PATCH v3 07/10] ppc/pnv: add XSCOM infrastructure

[Benjamin Herrenschmidt]

On Tue, 2016-09-27 at 11:10 +0200, Cédric Le Goater wrote:
> > 
> > > 
> > > +    PowerPCCPU *cpu = POWERPC_CPU(cs);
> > > +    CPUPPCState *env = &cpu->env;
> > > +
> > > +    cpu_synchronize_state(cs);
> > > +    env->spr[SPR_HMER] |= hmer_bits;
> > > +
> > > +    /* XXX Need a CPU helper to set HMER, also handle gneeration
> > > +     * of HMIs
> > > +     */
> 
> Ben, 
> 
> The CPU helper would be to replicate the value of the SPR_HMER in all
> the threads of the core I guess ? 

Nope, those HMER bits are per-thread afaik, but I dislike having a
device whack at CPU state...

Also when we do PR KVM of powernv, we'll want to sync the SPR with KVM
I suppose.

Cheers,
Ben.