Re: [Qemu-devel] [PATCH] virtio-serial: virtio console emergency write support

[Sascha Silbe]

Dear Amit,

Amit Shah <address@hidden> writes:

> On (Wed) 21 Sep 2016 [14:17:48], Sascha Silbe wrote:
>> Add support for the virtio 1.0 "emergency write"
>> (VIRTIO_CONSOLE_F_EMERG_WRITE) feature. This is useful for early guest
>> debugging and might be used in cases where the guest crashes so badly
>> that it cannot use virtqueues.
>> 
>> Disabled for compatibility machines to avoid exposing a new feature to
>> existing guests.
>> 
>> Reviewed-by: Cornelia Huck <address@hidden>
>> Signed-off-by: Sascha Silbe <address@hidden>
>
> This looks fine, but can you split the patch - adding
> find_first_connected_console(), set_config, and then finally enabling
> the emergency_write feature?

Sure. I've split it into two patches: One introducing
find_first_connected_console() + set_config() but with no way for the
guest to actually exploit it. The other patch exposing the emergency
write virtio feature to the guest and disabling it for older machines
using the compat property.

Will send the updated series once the build tests complete.

Sascha
-- 
Softwareentwicklung Sascha Silbe, Niederhofenstraße 5/1, 71229 Leonberg
https://se-silbe.de/
USt-IdNr. DE281696641