[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PATCH] block: modify top-id's comments
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [Qemu-block] [PATCH] block: modify top-id's comments |
|
Date: |
Wed, 28 Sep 2016 11:31:44 +0100 |
|
User-agent: |
Mutt/1.7.0 (2016-08-17) |
On Wed, Sep 28, 2016 at 01:30:39PM +0800, Wang WeiWei wrote:
Please send a proper commit message and commit description. "modify
top-id's comments" says almost nothing and there is no commit
description. I don't know why you are making this change so I can't
review and apply it.
> Signed-off-by: Wen Congyang <address@hidden>
> Signed-off-by: Changlong Xie <address@hidden>
> Signed-off-by: Wang WeiWei <address@hidden>
> Signed-off-by: zhanghailiang <address@hidden>
> Signed-off-by: Gonglei <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> ---
> qapi/block-core.json | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index ada3202..0935b81 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -2184,7 +2184,7 @@
> # @mode: the replication mode
> #
> # @top-id: #optional In secondary mode, node name or device ID of the root
> -# node who owns the replication node chain. Ignored in primary mode.
> +# node who owns the replication node chain. Must not be given in
> primary mode.
> #
> # Since: 2.8
> ##
> --
> 1.9.3
>
>
>
>
signature.asc
Description: PGP signature