[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 7/9] target-ppc: add stxvh8x instruction
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH v4 7/9] target-ppc: add stxvh8x instruction |
Date: |
Wed, 28 Sep 2016 09:13:06 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 |
On 09/27/2016 10:31 PM, Nikunj A Dadhania wrote:
> + if (ctx->le_mode) {
> + gen_helper_bswap16x4(xsh, xsh);
> + tcg_gen_qemu_st_i64(xsh, EA, ctx->mem_idx, MO_BEQ);
> + tcg_gen_addi_tl(EA, EA, 8);
> + gen_helper_bswap16x4(xsl, xsl);
> + tcg_gen_qemu_st_i64(xsl, EA, ctx->mem_idx, MO_BEQ);
You cannot clobber xsh and xsl like this. You need temporaries.
r~
- Re: [Qemu-devel] [PATCH v4 1/9] target-ppc: Implement mfvsrld instruction, (continued)
- [Qemu-devel] [PATCH v4 4/9] target-ppc: improve lxvw4x implementation, Nikunj A Dadhania, 2016/09/28
- [Qemu-devel] [PATCH v4 3/9] target-ppc: Implement mtvsrws instruction, Nikunj A Dadhania, 2016/09/28
- [Qemu-devel] [PATCH v4 5/9] target-ppc: improve stxvw4x implementation, Nikunj A Dadhania, 2016/09/28
- [Qemu-devel] [PATCH v4 8/9] target-ppc: add lxvb16x instruction, Nikunj A Dadhania, 2016/09/28
- [Qemu-devel] [PATCH v4 7/9] target-ppc: add stxvh8x instruction, Nikunj A Dadhania, 2016/09/28
- Re: [Qemu-devel] [PATCH v4 7/9] target-ppc: add stxvh8x instruction,
Richard Henderson <=
- [Qemu-devel] [PATCH v4 9/9] target-ppc: add stxvb16x instruction, Nikunj A Dadhania, 2016/09/28
- [Qemu-devel] [PATCH v4 6/9] target-ppc: add lxvh8x instruction, Nikunj A Dadhania, 2016/09/28
- Re: [Qemu-devel] [PATCH v4 0/9] POWER9 TCG enablements - part4, Nikunj A Dadhania, 2016/09/28
- Re: [Qemu-devel] [Qemu-ppc] [PATCH v4 0/9] POWER9 TCG enablements - part4, Thomas Huth, 2016/09/28