qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [Qemu-block] [PATCH] block: modify top-id's comments


From: Eric Blake
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH] block: modify top-id's comments
Date: Thu, 29 Sep 2016 08:35:14 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0

On 09/28/2016 05:31 AM, Stefan Hajnoczi wrote:
> On Wed, Sep 28, 2016 at 01:30:39PM +0800, Wang WeiWei wrote:
> 
> Please send a proper commit message and commit description.  "modify
> top-id's comments" says almost nothing and there is no commit
> description.  I don't know why you are making this change so I can't
> review and apply it.
> 

>> +++ b/qapi/block-core.json
>> @@ -2184,7 +2184,7 @@
>>  # @mode: the replication mode
>>  #
>>  # @top-id: #optional In secondary mode, node name or device ID of the root
>> -#          node who owns the replication node chain. Ignored in primary 
>> mode.
>> +#          node who owns the replication node chain. Must not be given in 
>> primary mode.

That, and your line exceeds 80 columns; please wrap it.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]