[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 1/9] ui: remove misleading comment from vnc_init_sta
From: |
Daniel P. Berrange |
Subject: |
[Qemu-devel] [PATCH 1/9] ui: remove misleading comment from vnc_init_state |
Date: |
Thu, 29 Sep 2016 16:45:32 +0100 |
The last line in vnc_init_state() says
/* vs might be free()ed here */
This was added in
commit 198a0039c5fca224a77e9761e2350dd9cc102ad0
Author: Gerd Hoffmann <address@hidden>
Date: Tue Jun 16 14:19:48 2009 +0200
vnc: rework VncState release workflow.
because the preceeding 'vnc_update_client()' could indeed
release the VncState instance.
The call to vnc_update_client() was removed not long after
though in
commit 1fc624122fb923c7fc4c1f426541d953e7df13c9
Author: Stefano Stabellini <address@hidden>
Date: Mon Aug 3 10:54:32 2009 +0100
single vnc server surface
and so the comment has been wrong ever since
Signed-off-by: Daniel P. Berrange <address@hidden>
---
ui/vnc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/ui/vnc.c b/ui/vnc.c
index 76a3273..5faf79b 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -3092,8 +3092,6 @@ void vnc_init_state(VncState *vs)
vs->mouse_mode_notifier.notify = check_pointer_type_change;
qemu_add_mouse_mode_change_notifier(&vs->mouse_mode_notifier);
-
- /* vs might be free()ed here */
}
static gboolean vnc_listen_io(QIOChannel *ioc,
--
2.7.4
- [Qemu-devel] [PATCH 0/9] Misc VNC server code cleanups, Daniel P. Berrange, 2016/09/29
- [Qemu-devel] [PATCH 1/9] ui: remove misleading comment from vnc_init_state,
Daniel P. Berrange <=
- [Qemu-devel] [PATCH 2/9] ui: remove 'enabled' and 'ws_enabled' fields from VncState, Daniel P. Berrange, 2016/09/29
- [Qemu-devel] [PATCH 3/9] ui: remove 'ws_tls' field from VncState, Daniel P. Berrange, 2016/09/29
- [Qemu-devel] [PATCH 5/9] ui: refactor method for setting up VncDisplay auth types, Daniel P. Berrange, 2016/09/29
- [Qemu-devel] [PATCH 4/9] ui: rename misleading 'VncDisplay' variables, Daniel P. Berrange, 2016/09/29
- [Qemu-devel] [PATCH 7/9] ui: remove bogus call to reset_keys() in vnc_init_state, Daniel P. Berrange, 2016/09/29
- [Qemu-devel] [PATCH 8/9] ui: move some initialization out of vnc_init_state, Daniel P. Berrange, 2016/09/29
- [Qemu-devel] [PATCH 6/9] ui: remove bogus call to graphic_hw_update() in vnc_listen_io, Daniel P. Berrange, 2016/09/29
- [Qemu-devel] [PATCH 9/9] ui: rename vnc_init_state to vnc_start_protocol, Daniel P. Berrange, 2016/09/29