[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4] hw/misc: Add simple measurement hardware
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH v4] hw/misc: Add simple measurement hardware |
|
Date: |
Fri, 30 Sep 2016 13:03:19 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 |
On 30/09/2016 12:45, Dr. David Alan Gilbert wrote:
>> >
>> > This version of the implementation depends on port io, but if there's
>> > interest I'll add mmio as well.
> Other than a couple of nits I'll mention below (and Stefan's comment)
> I don't see why we shouldn't have this; although we'll need a full vTPM
> for many uses, this is small and self-contained enough I can't
> see why not to have it. I'd also be tempted to prefix the commands in
> both qmp and hmp by an x- (i.e. mark experimental) so that you have the
> freedom to change them after it goes in initially
>
> Paolo: Does the acpi stuff make sense?
I think I'd prefer to use a QEMUxxxx identifier if it's not a problem
for Matthew, but that's really all I have to complain about it.
Paolo