qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v14 09/21] qapi: permit auto-creating single ele


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v14 09/21] qapi: permit auto-creating single element lists
Date: Fri, 30 Sep 2016 12:59:30 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0

On 09/30/2016 09:45 AM, Daniel P. Berrange wrote:
> When converting QemuOpts to a QObject, there is no information
> about compound types available, so when visiting a list, the
> corresponding QObject is not guaranteed to be a QList. We
> therefore need to be able to auto-create a single element QList
> from whatever type we find.
> 
> This mode should only be enabled if you have compatibility
> requirements for
> 
>    -arg foo=hello,foo=world
> 
> to be treated as equivalent to the preferred syntax:
> 
>    -arg foo.0=hello,foo.1=world
> 
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
>  include/qapi/qobject-input-visitor.h | 20 +++++++-
>  qapi/qobject-input-visitor.c         | 27 +++++++++--
>  tests/test-qobject-input-visitor.c   | 88 
> +++++++++++++++++++++++++++++++-----
>  3 files changed, 117 insertions(+), 18 deletions(-)
> 

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]