[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [libvirt] [PATCH v5 04/12] target-i386: Register aliase
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [libvirt] [PATCH v5 04/12] target-i386: Register aliases for feature names with underscores |
Date: |
Fri, 30 Sep 2016 14:56:42 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 |
On 09/30/2016 01:49 PM, Eduardo Habkost wrote:
> Registering the actual names containing underscores as aliases
> will allow management software to be aware that the old
> compatibility names are suported, and will make feat2prop() calls
s/suported/supported/
> unnecessary when using feature names.
>
> Also, this will help us avoid making the code support underscores
> on feature names that never had them in the first place. e.g.
> "+tsc_deadline" was never supported and doesn't need to be
> translated to "+tsc-deadline".
>
> In other word: this will require less magic translation of
> strings, and simple 1:1 match between the config options and
> actual QOM properties.
>
> Note that the underscores are still present in the
> FeatureWordInfo::feat_names arrays, because
> add_flagname_to_bitmaps() needs them to be kept. The next patches
> will remove add_flagname_to_bitmaps() and will allow us to
> finally remove the aliases from feat_names.
>
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
> target-i386/cpu.c | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v5 00/12] Add runnability info to query-cpu-definitions, Eduardo Habkost, 2016/09/30
- [Qemu-devel] [PATCH v5 01/12] tests: Add test case for x86 feature parsing compatibility, Eduardo Habkost, 2016/09/30
- [Qemu-devel] [PATCH v5 02/12] target-i386: List CPU models using subclass list, Eduardo Habkost, 2016/09/30
- [Qemu-devel] [PATCH v5 03/12] target-i386: Disable VME by default with TCG, Eduardo Habkost, 2016/09/30
- [Qemu-devel] [PATCH v5 04/12] target-i386: Register aliases for feature names with underscores, Eduardo Habkost, 2016/09/30
- Re: [Qemu-devel] [libvirt] [PATCH v5 04/12] target-i386: Register aliases for feature names with underscores,
Eric Blake <=
- [Qemu-devel] [PATCH v5 05/12] target-i386: Make plus_features/minus_features QOM-based, Eduardo Habkost, 2016/09/30
- [Qemu-devel] [PATCH v5 06/12] target-i386: Remove underscores from feat_names arrays, Eduardo Habkost, 2016/09/30
- [Qemu-devel] [PATCH v5 07/12] target-i386: Register properties for feature aliases manually, Eduardo Habkost, 2016/09/30
- [Qemu-devel] [PATCH v5 08/12] target-i386: xsave: Add FP and SSE bits to x86_ext_save_areas, Eduardo Habkost, 2016/09/30
- [Qemu-devel] [PATCH v5 09/12] target-i386: Move warning code outside x86_cpu_filter_features(), Eduardo Habkost, 2016/09/30
- [Qemu-devel] [PATCH v5 11/12] qmp: Add runnability information to query-cpu-definitions, Eduardo Habkost, 2016/09/30
- [Qemu-devel] [PATCH v5 10/12] target-i386: x86_cpu_load_features() function, Eduardo Habkost, 2016/09/30
- [Qemu-devel] [PATCH v5 12/12] target-i386: Return runnability information on query-cpu-definitions, Eduardo Habkost, 2016/09/30