[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v5 12/17] vfio/platform: fix a wrong returned value
From: |
Eric Auger |
Subject: |
[Qemu-devel] [PATCH v5 12/17] vfio/platform: fix a wrong returned value in vfio_populate_device |
Date: |
Thu, 6 Oct 2016 16:07:33 +0000 |
In case the vfio_init_intp fails we currently do not return an
error value. This patch fixes the bug. The returned value is not
explicit but in practice the error object is the one used to
report the error to the end-user and the actual returned error
value is not used.
Signed-off-by: Eric Auger <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
---
---
hw/vfio/platform.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/vfio/platform.c b/hw/vfio/platform.c
index 1a35da0..484e31f 100644
--- a/hw/vfio/platform.c
+++ b/hw/vfio/platform.c
@@ -508,6 +508,7 @@ static int vfio_populate_device(VFIODevice *vbasedev, Error
**errp)
irq.flags);
intp = vfio_init_intp(vbasedev, irq, errp);
if (!intp) {
+ ret = -1;
goto irq_err;
}
}
--
1.9.1
- Re: [Qemu-devel] [PATCH v5 08/17] vfio: Pass an Error object to vfio_connect_container, (continued)
- Re: [Qemu-devel] [PATCH v5 08/17] vfio: Pass an Error object to vfio_connect_container, David Gibson, 2016/10/10
- Re: [Qemu-devel] [PATCH v5 08/17] vfio: Pass an Error object to vfio_connect_container, Auger Eric, 2016/10/10
- Re: [Qemu-devel] [PATCH v5 08/17] vfio: Pass an Error object to vfio_connect_container, Markus Armbruster, 2016/10/10
- Re: [Qemu-devel] [PATCH v5 08/17] vfio: Pass an Error object to vfio_connect_container, Auger Eric, 2016/10/10
- Re: [Qemu-devel] [PATCH v5 08/17] vfio: Pass an Error object to vfio_connect_container, David Gibson, 2016/10/10
- Re: [Qemu-devel] [PATCH v5 08/17] vfio: Pass an Error object to vfio_connect_container, Markus Armbruster, 2016/10/10
- Re: [Qemu-devel] [PATCH v5 08/17] vfio: Pass an Error object to vfio_connect_container, David Gibson, 2016/10/10
[Qemu-devel] [PATCH v5 06/17] vfio/pci: Pass an error object to vfio_add_capabilities, Eric Auger, 2016/10/06
[Qemu-devel] [PATCH v5 10/17] vfio: Pass an error object to vfio_get_device, Eric Auger, 2016/10/06
[Qemu-devel] [PATCH v5 09/17] vfio: Pass an error object to vfio_get_group, Eric Auger, 2016/10/06
[Qemu-devel] [PATCH v5 12/17] vfio/platform: fix a wrong returned value in vfio_populate_device,
Eric Auger <=
[Qemu-devel] [PATCH v5 11/17] vfio/platform: Pass an error object to vfio_populate_device, Eric Auger, 2016/10/06
[Qemu-devel] [PATCH v5 14/17] vfio/pci: Conversion to realize, Eric Auger, 2016/10/06
[Qemu-devel] [PATCH v5 13/17] vfio/platform: Pass an error object to vfio_base_device_init, Eric Auger, 2016/10/06
[Qemu-devel] [PATCH v5 15/17] vfio/pci: Remove vfio_msix_early_setup returned value, Eric Auger, 2016/10/06
[Qemu-devel] [PATCH v5 16/17] vfio/pci: Remove vfio_populate_device returned value, Eric Auger, 2016/10/06
[Qemu-devel] [PATCH v5 17/17] vfio/pci: Handle host oversight, Eric Auger, 2016/10/06
Re: [Qemu-devel] [PATCH v5 00/17] Convert VFIO-PCI to realize, Markus Armbruster, 2016/10/07
Re: [Qemu-devel] [PATCH v5 00/17] Convert VFIO-PCI to realize, no-reply, 2016/10/10