[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qapi: allow blockdev-add for ssh
From: |
Richard W.M. Jones |
Subject: |
Re: [Qemu-devel] [PATCH] qapi: allow blockdev-add for ssh |
Date: |
Sat, 8 Oct 2016 11:54:50 +0100 |
User-agent: |
Mutt/1.5.20 (2009-12-10) |
On Sat, Oct 08, 2016 at 04:14:06PM +0530, Ashijeet Acharya wrote:
> Introduce new object 'BlockdevOptionsSsh' in qapi/block-core.json to
> support blockdev-add for SSH network protocol driver. Use only 'struct
> InetSocketAddress' since SSH only supports connection over TCP.
>
> +##
> +# @BlockdevoptionsSsh
> +#
> +# @server: host address and port number
> +#
> +# @path: path to the image on the host
> +#
> +# @user: user as which to connect
> +#
> +# @host_key_check defines how and what to check the host key against
> +#
> +# Since 2.8
> +##
> +{ 'struct': 'BlockdevoptionsSsh',
> + 'data': { 'server': 'InetSocketAddress',
> + 'path': 'str',
> + 'user': 'str',
> + 'host_key_check': 'str' } }
> +
This certainly reflects the current ssh settings.
If you really wanted to get into the down-and-dirty details, then
host_key_check has some structure. "yes", "no", "sha1:..." and
others. But probably we don't want all of that in the JSON.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines. Supports shell scripting,
bindings from many languages. http://libguestfs.org