Re: [Qemu-devel] [PATCH v8 1/2] linux-user: Add support for clock_adjtime() syscall

[Aleksandar Markovic]

Sure, I am going to send a new and corrected version of the series in short 
time.

Thanks,
Aleksandar
________________________________________
From: Peter Maydell address@hidden
Sent: Monday, October 10, 2016 3:35 AM
To: Aleksandar Markovic
Cc: Aleksandar Markovic; QEMU Developers; Riku Voipio; Laurent Vivier; Petar 
Jovanovic; Miodrag Dinic; Aleksandar Rikalo
Subject: Re: [PATCH v8 1/2] linux-user: Add support for clock_adjtime() syscall

On 10 October 2016 at 11:34, Aleksandar Markovic
<address@hidden> wrote:
> Thanks for bringing up this issue. LTP was not the reference for this
> implementation. Man page does not exist. The reference was kernel source.
> Apart from source code analysis. test examples were utilized to confirm
> the same behavior on real and emulated systems.

If no real world code or even LTP test code is relying on the
order in which error conditions are checked for, and the API
is not documented to make that kind of distinction, then I think
we should implement this the same way we do all other syscalls,
ie just check for EFAULT first.

thanks
-- PMM